Skip to content

Add GitHub CI, remove broken Travis one#63

Merged
wwylele merged 2 commits intowwylele:masterfrom
Tachi107:github-ci
Aug 6, 2025
Merged

Add GitHub CI, remove broken Travis one#63
wwylele merged 2 commits intowwylele:masterfrom
Tachi107:github-ci

Conversation

@Tachi107
Copy link
Copy Markdown
Contributor

@Tachi107 Tachi107 commented Aug 6, 2025

Since a commit recently broke tests, I thought it'd be useful to resurrect CI :)

I also had to stop passing -Wmaybe-unitialized unconditionally, as macOS' Xcode uses Clang.

@wwylele
Copy link
Copy Markdown
Owner

wwylele commented Aug 6, 2025

It looks like github doesn't run the test until this is merged, so I'll say this looks about right and merge it first

One thing that we lost from Travis is that there is a huge test set for almost every Teak instructions (that's what TEAKRA_TEST_ASSETS_DIR is for, which was stored in Travis cache). This test set needs to be re-generated from 3DS using the test generator in this repo. It would be great if we can add it back at some point

@wwylele wwylele merged commit 705c0b3 into wwylele:master Aug 6, 2025
@wwylele
Copy link
Copy Markdown
Owner

wwylele commented Aug 6, 2025

Amending my previous comment: it looks like the test case file is still valid here https://github.com/wwylele/teakra/blob/705c0b342b79a94eeabf9b2f39e042f672bd628b/src/test_verifier/CMakeLists.txt#L21C8-L21C66 (and I just downloaded a copy myself) so we don't need to generate it from 3DS again

@Tachi107 Tachi107 deleted the github-ci branch August 6, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants