Merged
Conversation
- README.txt is now README.md - depends-on is now validated to be a list, and is passed to templates - Some filenames are now forced to lower-case for naming compatibility reasons
- Provide default template directory complete with README and package file - Output README and package files exclusively from the template directory instead of defining write-*-file functions in quickproject - add .gitignore file - undo some case changes for the moment
- Add optional copyright notice header/footer to all default template files - Remove file-comment-header function (and add related stuff to each file) - Remove write-system-file and write-application-file - Add hooks to write .asd and initial .lisp file through the default template directory (and change their names as appropriate for output purposes so that we have files named <project>.asd and <project>.lisp)
Owner
|
I like this idea! It looks like I may have introduced a conflict by merging an older PR from last year. Also, it appears that the new code uses tabs instead of spaces. (If the current code uses tabs, that is a mistake, not by design.) Can you take a look at resolving the conflict and using spaces rather than tabs? |
Contributor
Author
|
@xach: That should do it (tested locally; it generates the expected output with and without |
Owner
|
Thanks! |
quicklisp
reviewed
Dec 20, 2017
quickproject.lisp
Outdated
|
|
||
| (defun template-pathname->output-name (path) | ||
| (flet ((mk-path (name) | ||
| (make-pathname |
There was a problem hiding this comment.
Can this be changed to (make-pathname :name name :defaults path) instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Here's a PR that moves most of the previously code-defined logic in
quickprojectinto a template directory. It's now possible to override a lot more of the default behavior without hacking on the project source code.I've still got a few opinions on what the
default-templateshould look like, but with the system as it is, this should be both a lot more flexible, and backwards compatible with the old way of doing things. (A README update might be in order too).Also, as written, this should resolve #2 and #4