Merged
Conversation
core to namedarray
negin513
approved these changes
Apr 23, 2024
Contributor
There was a problem hiding this comment.
Thanks for the PR. There has been some updates in the xarray API since xarray v2024.02.0 that introduced the error you are experiencing now #41 .
So these changes will break if there is any pinning to versions before v2024.02.0. I only suggest adding this to the requirements to ensure compatibility. Otherwise the changes look good to me.
pinning xarray>=v2024.02.0 where the array API internal changes were introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core to namedarray