Merged
Conversation
Define project metadata in pyproject.toml! Required dependencies are now listed under the [project] section instead of in requirements.txt. Versioneer config has also been moved from setup.cfg to [tool.versioneer].
Package name is cupy_xarray, not cupy-xarray.
Remove requirements_test.txt file, moving the test dependencies to pyproject.toml instead. Also updated MANIFEST.in to remove the requirements.txt entry.
weiji14
changed the title
Still need these two lines so that the sdist won't have a 0.0.0 version. Xref https://github.com/python-versioneer/python-versioneer/blob/0.29/INSTALL.md#common-steps
weiji14
commented
Jun 25, 2024
Comment on lines
+7
to
+8
| version=versioneer.get_version(), | ||
| cmdclass=versioneer.get_cmdclass(), |
Member
Author
There was a problem hiding this comment.
Unfortunately, we still need a setup.py file with these versioneer.get_version() and versioneer.get_cmdclass() calls, otherwise the built sdist and wheel will have an invalid 0.0.0 version 😞 See python-versioneer/python-versioneer#381.
If we really want to remove the setup.py file, we can discuss about replacing versioneer with setuptools-scm, and do it in a follow-up PR.
Not needed after #49
dcherian
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define project metadata in pyproject.toml!
TODO:
setup.pysetup.cfgrequirements.txtrequirements_test.txtReferences:
Fixes #47