Skip to content

Add XProj dependency#29

Closed
scottyhq wants to merge 2 commits intoxarray-contrib:mainfrom
scottyhq:xprojdev
Closed

Add XProj dependency#29
scottyhq wants to merge 2 commits intoxarray-contrib:mainfrom
scottyhq:xprojdev

Conversation

@scottyhq
Copy link
Copy Markdown
Contributor

Addresses #13

Also adds some more development notes (I'm new to hatch so took a bit to understand how to use it)

@scottyhq scottyhq requested a review from benbovy May 13, 2025 12:58
Comment thread tests/test_raster_index.py Outdated
Comment on lines +10 to +11
# TODO: hook up xproj to remove need for import?
import xproj
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcherian
Copy link
Copy Markdown
Contributor

Nice, please merge whenever you all think this is ready.

@scottyhq
Copy link
Copy Markdown
Contributor Author

While this 'works' after talking with @benbovy we're thinking a better strategy to actually address #13 is to not yet have xproj as a dependency and instead focus on this case:

  1. Ensure CRS-matching during (exact) alignment of datasets even in cases where a spatial reference coordinate is missing

https://github.com/xarray-contrib/xvec/blob/5affd7ac591bbdef2722c5eac4b976823384e8ed/xvec/index.py#L102-L111

The xproj integration can happen later as it would needed for specific use-cases (xarray-contrib/xproj#25) but not necessarily required as a dependency

@benbovy benbovy mentioned this pull request Jun 4, 2025
@benbovy
Copy link
Copy Markdown
Member

benbovy commented Jun 30, 2025

I'm closing this in favor of #31 where I just added the example notebook.

@benbovy benbovy closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants