Merged
Conversation
`cumprod` / `cumulative_prod` are not part of the array API
`Variable` implements n-d cum ops by iterating over the axes.
Member
Author
|
looks like We could probably merge Other than that, this should be ready for review, @TomNicholas |
Member
Author
|
looks like that finally did it. So with that we only need to decide what to do about the code duplication (or if we can, as I would suggest, leave it as is), and this should be good to merge. |
Member
Author
|
assuming that the code duplication is nothing urgent, I'm going to go ahead and merge |
Member
|
Sorry Justus! This looks great though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few more reduction (or index reduction) tests, which should cover everything
xarraysupports and which is part of the array API.xarrayadditionally provides sorting-based reductions likequantileandmedian, plusrankwhich I don't quite understand.