Add longitude normalization to CUDA inverse projection kernels#1089
Merged
Conversation
Six CUDA inverse projection kernels returned raw `lam + lon0` without wrapping to [-pi, pi]. The CPU Numba kernels all pass through `_norm_lon_rad()` before converting to degrees. Without normalization, coordinates far from the central meridian (e.g., near the antimeridian) can produce longitude values outside [-180, 180]. Added `_d_norm_lon_rad` device function and applied it to: - LCC inverse (2 return paths) - AEA inverse - CEA inverse - Sinusoidal inverse - LAEA inverse - Polar Stereographic inverse Also removed dead code in `_tmerc_params()` where a loop computed a value that was immediately overwritten.
…1088) - Add _norm_lon_rad to CPU _lcc_inv_point early-return (rho < 1e-30) for consistency with the CUDA fix - Move _WGS84_E2/_WGS84_A constants to top of test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1088
Summary
CUDA longitude normalization: Six CUDA inverse projection kernels returned raw
lam + lon0without wrapping to [-pi, pi], while the CPU Numba kernels all pass through_norm_lon_rad(). Added a_d_norm_lon_raddevice function and applied it to LCC, AEA, CEA, Sinusoidal, LAEA, and Polar Stereographic inverses (7 return statements total).Dead code cleanup: Removed an unused loop in
_tmerc_params()that computeddCnvia a broken recurrence, immediately overwritten by the correct_clenshaw_complex_py()call.Test plan
test_sinusoidal_round_trip_stays_in_rangeverifies CPU sinusoidal inverse keeps longitude in [-180, 180] near antimeridiantest_lcc_round_trip_stays_in_rangeverifies CPU LCC inverse round-trip_d_norm_lon_radreplicates