Fix target_elev contaminating horizon in dask viewshed distance sweep (#1098)#1099
Merged
Conversation
…#1098) _sweep_ring used a single gradient array that included target_elev for both the visibility test and the horizon update. The horizon profile should only reflect raw terrain gradients — target_elev is the height offset of the thing you're looking for, not extra height on every cell that might block your view. Split the gradient into two arrays: gradients (with target_elev, for visibility) and terrain_gradients (without, for horizon update).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split _sweep_ring gradient into two arrays: one with target_elev for visibility testing, one without for horizon updates. Added regression test. Fixes #1098.