Fix inverted decay and off-by-one in bump spread (#1102)#1103
Merged
Conversation
_finish_bump had two bugs: 1. d2/s gave more height to farther pixels (inverted). Changed to (s-d2)/s so adjacent pixels get the most contribution. 2. range(x-spread, x+spread) missed the last pixel. Changed to x+spread+1 for both axes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1102.
_finish_bumphad two bugs that affected every bump this module produces:Inverted decay:
d2 / sgave more height to pixels farther from center. Changed to(s - d2) / sso adjacent pixels get the most contribution and the edge tapers to zero.Off-by-one:
range(x - spread, x + spread)excluded the last pixel on the positive side becauserangeexcludes its upper bound. Changed tox + spread + 1for both axes.Both bugs are in
_finish_bump, which all four backends share.Test plan
test_bump_decay_strongest_at_center_1102: center > adjacent > fartest_bump_spread_reaches_both_sides_1102: pixels on both sides of center are reached, outside spread is zerotest_bump.pysuite: 10 passed