Propagate NaN from curve_number in curve_number_runoff (#1104)#1105
Merged
Conversation
The NaN fixup only checked np.isnan(p), missing NaN in the curve number raster. When CN is NaN, P > NaN is False, so np.where wrote 0.0 instead of NaN. Now checks both p and cn in all three backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1104.
curve_number_runoffreturned 0 instead of NaN when thecurve_numberraster had NaN cells. The NaN fixup only checkednp.isnan(p)(rainfall), missingnp.isnan(cn). When CN is NaN,P > NaNis always False, sonp.wheretook the else-branch and wrote 0.0.Fixed in all three backend functions (
_cn_runoff_numpy,_cn_runoff_cupy,_cn_runoff_dask) to check bothpandcnfor NaN.Test plan
test_cn_runoff_nan_curve_number_1104: NaN curve number produces NaN, valid CN produces valid runofftest_flood.pysuite: 82 passed