Fix multi-metric output mislabeling in glcm_texture (#1106)#1107
Merged
Conversation
The kernel always writes output slots in VALID_METRICS order, but coordinate labels were set from the user's list. When metrics were requested in non-standard order (e.g. ['entropy', 'contrast']), result.sel(metric='contrast') returned entropy values. Added _sorted_metrics() to reorder the user's list to match the kernel's output order. 10 new tests covering various orderings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1106. When
glcm_texture()received metrics in any order other than the internalVALID_METRICSorder, the output coordinate labels didn't match the actual data. For example,glcm_texture(agg, metric=['homogeneity', 'contrast'])would return a DataArray whereresult.sel(metric='contrast')actually contained homogeneity values. Silent data corruption.The kernel always writes output slots in
VALID_METRICSorder (contrast first, entropy last). The fix sorts the user's metric list into this same order before building coordinate labels.Test plan