Fix balanced_allocation OOM: lazy source extraction + memory guard#1115
Merged
Conversation
Parallel subagent triage + ralph-loop workflow for auditing all xrspatial modules for performance bottlenecks, OOM risk under 30TB dask workloads, and backend-specific anti-patterns.
7 tasks covering command scaffold, module scoring, parallel subagent dispatch, report merging, ralph-loop generation, and smoke tests.
…1114) - _extract_sources now uses da.unique() for dask arrays instead of materializing the full raster to find source IDs - Add memory guard before computing N cost surfaces: estimates N * array_bytes + overhead and raises MemoryError if it would exceed 80% of available RAM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_extract_sourcesnow usesda.unique()for dask arrays instead of materializing the full raster to find source IDsN * array_bytes + overheadand raisesMemoryErrorif it would exceed 80% of available RAMContext
Found during performance sweep triage (#1114). The algorithm is inherently O(N * array_size) in memory since it holds N cost-distance surfaces simultaneously. This can't be fundamentally fixed without a different algorithm, but the guard catches it early with a clear message instead of letting the system OOM mid-computation.
Test plan
test_balanced_allocation_memory_guard-- verifies MemoryError raised when available memory is insufficienttest_extract_sources_dask_no_materialize-- verifiesda.unique()used for dask source extraction