Fix normalize dask paths: replace boolean indexing with lazy reductions#1125
Merged
Conversation
Parallel subagent triage + ralph-loop workflow for auditing all xrspatial modules for performance bottlenecks, OOM risk under 30TB dask workloads, and backend-specific anti-patterns.
7 tasks covering command scaffold, module scoring, parallel subagent dispatch, report merging, ralph-loop generation, and smoke tests.
…#1124) Replace `data[finite_mask]` (boolean fancy indexing that materializes dask arrays) with `da.where(finite_mask, data, nan)` + `da.nanmin()`/ `da.nanmax()`/`da.nanmean()`/`da.nanstd()` for lazy per-chunk reductions. Guard division by zero in rescale with safe_range to prevent inf/nan in lazy evaluation (da.where evaluates both branches).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data[finite_mask](boolean fancy indexing that materializes dask arrays) withda.where(finite_mask, data, nan)+da.nanmin()/da.nanmax()/da.nanmean()/da.nanstd()safe_rangeto prevent inf/nan from lazy branch evaluationContext
Found during performance sweep (#1124). Boolean fancy indexing on dask arrays forces full materialization into a single chunk. The lazy reduction functions (
da.nanminetc.) do per-chunk reductions that never materialize the full array.Test plan