Numba-ize visibility module loops (#1177)#1179
Merged
Merged
Conversation
JIT-compile _bresenham_line, _fresnel_radius_1, and the three inner loops of line_of_sight (distance, visibility, Fresnel) via @ngjit. _bresenham_line now returns an (N, 2) int64 array instead of a list of tuples; _extract_transect and tests updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_bresenham_line,_fresnel_radius_1, and the three inner loops ofline_of_sight()(distance, visibility, Fresnel) with@ngjit_bresenham_linenow returns an(N, 2)int64 array instead of a list of tuples;_extract_transectand tests updated to match_los_kernelfunction fuses the distance, visibility, and Fresnel loops into a single numba-compiled passTest plan
Closes #1177