Drop final master references after default branch rename#1266
Merged
Conversation
Cleans up the few occurrences of "master" left in the repo after the master->main default branch rename: - test.yml pins actions/checkout and actions/setup-python to versioned tags (@v4 and @v5) instead of @master, matching the version pattern already used in benchmarks.yml. This also fixes a minor stability concern: tracking @master picks up unreleased changes from those actions' repos. - conf.py renames master_doc to root_doc (Sphinx's modern canonical name; supported as an alias since Sphinx 4.0). - docs-navbar.html template updated to match. - The Sphinx docs URL in the conf.py header comment now points at the stable docs path. - Trims an obsolete "defaults to master" comment in asv.conf.json since branches is explicitly set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up the last few "master" occurrences that survived the rename PRs (#1255, #1260):
.github/workflows/test.yml: pinsactions/checkout@master->@v4andactions/setup-python@master->@v5, matching the version tags already used inbenchmarks.yml. Tracking@masterexposes the workflow to unreleased changes in those actions' repos.docs/source/conf.py: renamesmaster_doctoroot_doc.root_dochas been Sphinx's canonical name since Sphinx 4.0;master_docremains as a deprecated alias. Also updates the header-comment URL from the oldsphinx-doc.org/en/master/configredirect to the stable docs path.docs/source/_templates/docs-navbar.html: matchingmaster_doc->root_docrename.benchmarks/asv.conf.json: trims the now-irrelevant "defaults to master" template comment (thebrancheskey is explicitly set).After this merges, no
masterreferences remain in.github/,docs/,benchmarks/,README.md,CONTRIBUTING.md, or.claude/commands/.Test plan
pytestworkflow uses the newly-pinned actions).pathto(root_doc)in the navbar template).