Add memory guard to geodesic slope/aspect (#1283)#1285
Merged
Conversation
The geodesic method in slope() and aspect() allocates a (3, H, W) float64 stacked array (data, lat, lon) per call with no memory guard. A large enough lat/lon-tagged raster passed to slope(method='geodesic') or aspect(method='geodesic') will OOM the process. Add _check_geodesic_memory(rows, cols, func_name) in xrspatial/geodesic.py, modeled on _check_kernel_memory in xrspatial/morphology.py. It raises MemoryError when the stacked float64 buffer plus the float32 output plus a padding allowance exceeds 50% of available RAM. slope() and aspect() call it in the geodesic branch before dispatch. Tests cover the guard firing on an oversized raster, normal-sized rasters passing through, and the planar method skipping the guard entirely. Records the audit + fix in .claude/sweep-security-state.csv.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slope()andaspect()allocates a(3, H, W)float64 stacked array (data, lat, lon) per call with no memory guard. A large enough lat/lon-tagged raster passed toslope(method='geodesic')oraspect(method='geodesic')will OOM the process._check_geodesic_memory(rows, cols, func_name)toxrspatial/geodesic.py, modeled on_check_kernel_memoryinxrspatial/morphology.py. It raisesMemoryErrorwhen the stacked float64 buffer plus the float32 output plus a padding allowance exceeds 50% of available RAM.slope()andaspect()call it in the geodesic branch before dispatch.Closes #1283.
Test plan
pytest xrspatial/tests/test_geodesic_slope.py xrspatial/tests/test_geodesic_aspect.py-> 39 passedpytest xrspatial/tests/test_slope.py xrspatial/tests/test_aspect.py-> 105 passed (no regression on the planar paths)TestGeodesicSlopeMemoryGuardandTestGeodesicAspectMemoryGuardcover: guard fires on oversized raster, normal-size raster passes, planar method skips guard