Guard fill_d8() against unbounded memory allocations (#1334)#1336
Merged
Conversation
Add _check_memory / _check_gpu_memory budget checks (32 B/px CPU, 32 B/px GPU, 50% threshold) to the eager numpy and cupy backends in fill_d8.py. Dask backends skip the guard because per-tile allocations are already bounded by chunk size. Adds 5 memory-guard tests (numpy raise, normal-input pass, dask bypass, error message, cupy raise).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_memory/_check_gpu_memorybudget checks (32 B/px CPU, 32 B/px GPU, 50% threshold) to the eager numpy and cupy backends infill_d8.py.Fixes #1334.
Background
The eager numpy path allocated
dem_f64(float64 copy),ring((h+2, w+2) float64),fill(kernel output, float64), and an extranp.where(...)copy whenz_limitis set, ~32 B/pixel of working memory plus the caller's input._fill_cupyallocateddem_f64+fill+ acp.where(...)output + an optionalz_limitcp.where(...), ~32 B/pixel of GPU memory. Neither backend checked against available memory, so a 50000x50000 numpy DEM asked for ~60 GB of host memory before anything errored out.Same guard pattern was added in flow_accumulation (#1318/#1319), sieve (#1296), kde (#1287), resample (#1295), focal (#1286), geodesic (#1283), mahalanobis (#1288), true_color (#1291), diffuse (#1267), erode (#1275), emerging_hotspots (#1274), dasymetric (#1261), sky_view_factor (#1299), surface_distance (#1303).
fill_d8is the depression-filling preprocessing step most hydrology pipelines run first on the full DEM, so it needs the same guard.Test plan
pytest xrspatial/hydro/tests/test_fill_d8.py-- 24 passedpytest xrspatial/hydro/tests/-- 636 passed