Guard stream_order_dinf() against unbounded memory allocations (#1350)#1354
Merged
Conversation
Adds _check_memory and _check_gpu_memory helpers, wired into the numpy and cupy dispatch in stream_order_dinf(). Dask backend skips the guard since per-tile allocations are already bounded by chunk size. CPU peak working set is ~40 B/px for Strahler (order f64, in_degree i32, max_in f64, cnt_max i32, queue_r i64, queue_c i64), ~32 B/px for Shreve. We budget the worst case. GPU peak is 37 B/px kernel + 8 B/px fa_cp cast; 40 B/px conservative. Threshold is 50% of available memory. Tests (5): numpy oversize raises, numpy normal succeeds, dask bypasses, error message mentions HxW + dask, cupy oversize raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1350.
Adds memory guards to
stream_order_dinf, matching the pattern used forstream_order_d8(#1331) andstream_link_dinf(#1347):_check_memory: 40 B/px CPU (Strahler kernel peak: order f64, in_degree i32, max_in f64, cnt_max i32, queue_r i64, queue_c i64). Shreve dropsmax_in/cnt_maxand is ~32 B/px. We budget for the worst case._check_gpu_memory: 40 B/px GPU (37 B/px kernel + 8 B/pxfa_cpcast).D-inf encodes one continuous downstream angle per cell (two bracketing neighbors with proportional fractions), so there is no (8, H, W) per-neighbor weight buffer like MFD. The working set matches the d8 budget.
Tests (5):
Full hydro suite passes apart from the known flake
test_stream_link_dask_temp_cleanup.