Guard snap_pour_point_d8() against unbounded memory allocations (#1362)#1366
Merged
Conversation
The numpy and cupy dispatches each allocate three full H*W float64 buffers (flow_accum cast, pour_points cast, output) -- ~24 B/px with no memory check. Add per-module _check_memory and _check_gpu_memory helpers modeled on flow_accumulation_d8 (#1318/#1319), wired into the public dispatch before the eager allocations. Dask paths use windowed slicing and skip the guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1362.
Summary
snap_pour_point_d8each allocate three full H*W float64 buffers (flow_accum cast, pour_points cast, output) -- ~24 B/px with no memory check._check_memoryand_check_gpu_memoryhelpers modeled on the flow_accumulation(): numpy and cupy backends have no memory guard #1318/Guard flow_accumulation() against unbounded eager allocations (#1318) #1319 flow_accumulation_d8 guard. Threshold is 50% of available host RAM (or free GPU RAM).Test plan
pytest xrspatial/hydro/tests/test_snap_pour_point_d8.py-- 27 passed (5 new memory-guard tests underTestMemoryGuard)test_basin_dask_temp_cleanup,test_stream_link_dask_temp_cleanup)