Guard flow_path_d8() against unbounded memory allocations (#1364)#1368
Merged
Conversation
Add a 50%-of-available-memory guard to the eager numpy and cupy backends of flow_path_d8(). The numpy path holds a float64 working copy of flow_dir, a float64 copy of start_points, and the float64 output (~21 B/pixel measured, 24 B/pixel budgeted). The cupy path detours through the host kernel, so it pays the same CPU budget plus device input + output. Dask and dask+cupy backends already stream chunks lazily, so they skip the guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1364.
Add a 50%-of-available-memory guard to the eager numpy and cupy backends of
flow_path_d8(). The dask and dask+cupy backends already stream chunks lazily and skip the guard.The numpy path holds a float64 working copy of
flow_dir, a float64 copy ofstart_points, and the float64 output. Measured peak viatracemallocon a 2000x2000 grid: ~21 B/pixel; budgeted at 24 B/pixel. The cupy path detours through the CPU kernel, so it pays the same host budget plus device input + output (~32 B/pixel device).Pattern follows #1318, #1319, #1303, #1334, #1338, #1339, #1344, #1355.
Test plan
pytest xrspatial/hydro/tests/test_flow_path_d8.py— 22 passed (17 existing + 5 new)pytest xrspatial/hydro/tests/— 731 passed (2 known-flaky temp-cleanup tests deselected)MemoryErrorwhen host memory is patched lowMemoryErrorwhen GPU memory is patched low