Validate dtypes per band in mahalanobis() (#1376)#1379
Merged
Conversation
`mahalanobis()` relied solely on `validate_arrays()` for input validation, which only checks matching shape and array-type. Boolean and other non-numeric DataArrays were silently coerced to float64. Call `_validate_raster()` on every band before the existing checks so non-numeric inputs raise a clear error at the API boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mahalanobis()only ranvalidate_arrays()on its bands, which checks matching shape and array-type but not dtype. Boolean and other non-numeric DataArrays were silently coerced to float64 instead of being rejected._validate_raster()on each band first, then the existing shape/array-type check, then the memory guard, then compute.Changes
xrspatial/mahalanobis.py: import_validate_rasterand loop overbandsat the top ofmahalanobis(), validating each as a 2-D numeric DataArray.xrspatial/tests/test_mahalanobis.py: three tests covering the bool reject path, the string reject path, and the mixed-numeric (float + int) positive path.Related
Test plan
pytest xrspatial/tests/test_mahalanobis.py-- 24 passed (21 prior + 3 new).