Skip to content

Record accuracy sweep results for bilateral#1406

Merged
brendancol merged 2 commits into
mainfrom
accuracy-sweep-bilateral
May 2, 2026
Merged

Record accuracy sweep results for bilateral#1406
brendancol merged 2 commits into
mainfrom
accuracy-sweep-bilateral

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

Summary

Records accuracy sweep results for the bilateral module in .claude/sweep-accuracy-state.csv. No issues found.

Audit covered all five accuracy categories across numpy, cupy, dask+numpy, and dask+cupy backends:

  • Floating point: float64 used throughout. Sigma underflow already validated via sqrt(np.finfo(float64).tiny) lower bound; oversize sigma clamped to max(rows, cols).
  • NaN handling: NaN center returns NaN; NaN neighbors are skipped without incrementing the denominator. The w_sum > 0.0 guard prevents division by zero.
  • Off-by-one: map_overlap depth equals kernel radius. CUDA bounds use strict <. Loop bounds are symmetric and inclusive of y+radius.
  • Earth curvature: not applicable (pixel space).
  • Backend consistency: numpy and cupy paths use identical algorithms with float64 dtype. Dask paths route through the same chunk function.

Test plan

  • Read xrspatial/bilateral.py, xrspatial/utils.py, xrspatial/tests/general_checks.py, xrspatial/tests/test_bilateral.py
  • CSV update visible in diff

@github-actions github-actions Bot added the performance PR touches performance-sensitive code label May 2, 2026
@brendancol
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: brendancol <433221+brendancol@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

@copilot resolve the merge conflicts in this pull request

Merged origin/main into this branch in a126bbe. The merge resolved automatically with no conflicts — the CSV update on this branch was cleanly integrated with the upstream changes to glcm.py, sky_view_factor.py, and their tests.

@brendancol brendancol merged commit 1742773 into main May 2, 2026
1 check was pending
@brendancol brendancol deleted the accuracy-sweep-bilateral branch May 4, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants