flood: validate mannings_n DataArray values#1438
Merged
Merged
Conversation
travel_time and flood_depth_vegetation accept mannings_n as either a scalar or a DataArray. The scalar path enforced mannings_n > 0, but the DataArray path performed no validation. A roughness raster containing 0 silently produced inf velocity / 0 travel time; negatives produced negative travel time; NaN/Inf propagated. Add a _validate_mannings_n_dataarray helper that calls _validate_raster for structural checks and then verifies all values are finite and strictly positive. Wired into both travel_time (line 419) and flood_depth_vegetation (line 853). 6 new tests in TestMannigsNDataArrayValidation.
brendancol
added a commit
that referenced
this pull request
May 3, 2026
Records the 11 PRs filed this round: - hydro: HIGH flow_direction_mfd memory guard (PR #1424); MEDIUM bundles for _validate_raster on secondary args (#1426), scalar param validation (#1428), and cellsize validation (#1430). - reproject: MEDIUM bundles for _validate_raster (#1432), grid/bounds/ precision validation (#1434), and NaN/Inf rejection (#1436). - flood: mannings_n DataArray validation (#1438). - pathfinding: waypoint cap + _validate_raster (#1440). - polygonize: _validate_raster (#1442). - terrain: scratch memory guard + scalar validation (#1444).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1437.
Summary
_validate_mannings_n_dataarray()helper that enforces finite, strictly positive values whenmannings_nis supplied as a DataArray (the scalar path already enforces this).travel_timeandflood_depth_vegetation.ValueErrorinstead of silently producing inf velocity / 0 / NaN output.Test plan
TestMannigsNDataArrayValidation.