geotiff: add max_cloud_bytes to canonical reader kwarg order (#1957)#1958
Merged
Conversation
PR #1932 added the max_cloud_bytes kw-only param to open_geotiff but did not update _CANONICAL_ORDER in test_reader_kwarg_order_1935.py. The signature-parity test has been failing on main on every Python version ever since, blocking CI for every open PR. Insert max_cloud_bytes between max_pixels and on_gpu_failure to match the actual signature. The other readers (read_geotiff_dask, read_geotiff_gpu, read_vrt) don't expose this kwarg yet; the _assert_canonical helper intersects with the canonical tuple, so they keep passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1957. Unblocks CI on
mainand on every open PR.PR #1932 added the
max_cloud_byteskw-only param toopen_geotiffbut did not update_CANONICAL_ORDERintest_reader_kwarg_order_1935.py. The signature-parity test has been failing onmainon every Python version since that commit landed, which in turn makes every other open PR's CI fail (with the rest of the matrix CANCELLED via fail-fast).Insert
"max_cloud_bytes"between"max_pixels"and"on_gpu_failure"to match the real signature. The other readers (read_geotiff_dask,read_geotiff_gpu,read_vrt) don't expose this kwarg yet;_assert_canonicalintersects with the canonical tuple, so they keep passing without any change.Test plan
pytest xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py— all 5 tests pass locally.