Skip to content

Conversation

@JessicaS11
Copy link
Contributor

Populated the scipy2022 workshop content by adding url links in the table of contents to that section. For new content, I created notebooks with high level framing for us to fill in content.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JessicaS11 JessicaS11 linked an issue Jun 10, 2022 that may be closed by this pull request
@JessicaS11
Copy link
Contributor Author

I'll note that this successfully builds for me locally...

@dcherian
Copy link
Contributor

dcherian commented Jun 13, 2022

I like it! Nice work

I had some comments but then just implemented them to save time. Please feel free to revert any of the commits if you don't like it.

  1. Renamed "scipy-tutorial" folder to "fundamentals"
  2. Moved dask material to under the "advanced" folder.
  3. Moved the "thinking like xarray" material to "intermediate" folder
  4. Listed notebooks under "Fundamentals", "Intermediate", "Advanced" headings in the left sidebar

Followups:

  • I think we should delete "intro to dask" notebook and link to dask docs instead.
  • We could move "Xarray in 45 minutes" from under OceanHackWeek and list it under an "Overview" heading above "Fundamentals"

Looks like this now:
image

Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! +1 to moving to official tutorials and user guides in other repositories (dask). Also having an overview/quickstart/whirlwind tour up top. I say we merge this and follow in separate PRs

@dcherian
Copy link
Contributor

Thanks @JessicaS11 Merging since this seems to be a blocker for other work. We can keep refining in future PRs

@dcherian dcherian merged commit 1109081 into xarray-contrib:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modularize existing fundamentals content

3 participants