fix: Concurrent Scraper Waitgroups #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue I noticed during debugging (not sure if also an issue when running normal). Initiating a scrape would send CPU to 100% and lock xbvr until the app is killed.
Contributor
|
Legend, this has been a huge pain in the butt since it started happening. Pretty sure its only development. PR seems to work for me, unless I just keep getting one of the 0.5% of the times when it worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue I noticed during debugging (not sure if also an issue when running normal). My development environment became useless to debug scrapers. Initiating a scrape would send CPU to 100% and lock xbvr until the app was killed. Without this I could not step through code during execution. It would happen 99.5 times out of 100.