[Android] remove old ndk as not used#697
Merged
glennguy merged 2 commits intoxbmc:Nexusfrom Sep 28, 2021
matthuisman:remove_ndk
Merged
[Android] remove old ndk as not used#697glennguy merged 2 commits intoxbmc:Nexusfrom matthuisman:remove_ndk
glennguy merged 2 commits intoxbmc:Nexusfrom
matthuisman:remove_ndk
Conversation
Contributor
|
Is there a way you can do this in git so that it will show as the file getting renamed? Maybe it would work across 2 commits? If not maybe just better to delete wvdecrypter_android and not rename wvdecrypter_android_jni. I'm thinking about being able to use blame and history, that's all. |
Contributor
Author
|
Haha. I had the same thought. I then did over two commits but when making the pull request, it showed as the same. But now I think that's because the pr window shows the changes all together! I'll try again. |
Contributor
Author
|
@glennguy |
Contributor
Author
|
@glennguy |
phunkyfish
approved these changes
Sep 28, 2021
Contributor
Author
|
@glennguy ready now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove wvdecrypter_android.cpp and CMakeLists.txt.ndk
rename wvdecrypter_android_jni.cpp to wvdecrypter_android.cpp
update CMakeLists.txt
Pretty sure we dont use ndk anymore as kodi was moved to jni