Using Fastlane::Actions::VerifyXcodeAction for verify_app_cert #361
Conversation
|
It is reasonable to keep verification logic in one well maintained place (Fastlane). Also your PR makes code easier to understand 👍 |
lib/xcode/install.rb
Outdated
| apple_team_identifier_result = cert_info['team_identifier'] == TEAM_IDENTIFIER | ||
| apple_authority_result = cert_info['authority'].include?(AUTHORITY) | ||
| apple_team_identifier_result && apple_authority_result | ||
| begin |
There was a problem hiding this comment.
You can remove a level of nesting here, since a def is an implicit begin:
https://forum.upcase.com/t/implicit-begin/205
🤷♂
There was a problem hiding this comment.
+1, probably not a a bad idea
There was a problem hiding this comment.
I didn't know this syntax. Thanks!
|
@marcomorain I updated the code in-place, if you could take a look to make sure everything is alright, that'd be great @Kesin11 Thanks for the fix! |
|
This may not be a complete fix. I now get this message during validation |
|
@KirkMartinez In my newest result of installing Xcode shows Xcode 10.2.1 can be installed 👍 |
|
Please someone review or merge it. |
|
Apologies, I think this is probably fine to merge. In my testing installing Xcode 10.2.1 also worked, so I think there must be some other reason why it was not working for @KirkMartinez |
|
@Kesin11 Your end to end test setup looks pretty sweet, do you want to submit a PR for that as well? |
|
@milch Thanks for merge! |
|
Popping a new release with this in it in a bit! |
|
Released in |
6 participants
fix #360
Current version of xcode-install (v2.6.1) can not install Xcode 10.x due to verify certificate step.
In #338 @salmanasiddiqui suggested using VerifyXcodeAction instead of VerifyBuildAction.
I tried his suggest and it works.
I confirmed in my forked repositories that this code fix can actually install Xcode 10.x.
https://github.com/Kesin11/xcode-install/runs/276027924
However, I know this fix is not better because it will be more dependent on fastlane. In addition, additional logs that from VerifyXcodeAction have been displayed.
Another choice is only copy accepted codesign sets from verify_xcode.rb.
Which choice should I take?