fix flaky specs when progress_content is nil
#434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerluan
changed the title
progress_content is nil
joshdholtz
approved these changes
Apr 27, 2021
Member
joshdholtz
left a comment
joshdholtz
left a comment
There was a problem hiding this comment.
This looks good to me! I ran this update locally and Xcode seemed to still install 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #430
Some times
progress_content = File.read(progress_log_file).split("\r").lastwould return nil, probably because the file although existed, it didn't have any content (temporarily at least).In those cases,
progress_contentwould be nil and crash down the process, causing the failed specs described in #430. This PR aims to fix that.