Add header for internal use #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamstein-eb
suggested changes
Apr 22, 2020
adamstein-eb
left a comment
adamstein-eb
left a comment
There was a problem hiding this comment.
Looks like lines 81 and 82 have tab characters in them which is why the Travis CI jobs failed. Can you replace them with spaces?
Contributor
Author
|
Removed tabs but still some of the builds fail |
Contributor
|
I was able to get this working by adding the following to the
|
osowskit
approved these changes
May 4, 2020
tushdante
added a commit
to tushdante/twitter-python-ads-sdk
that referenced
this pull request
Oct 5, 2020
Testing CI/CD integration Update pythonpublish.yml Update __init__.py Update __init__.py Add github actions (xdevplatform#249) * Added pythonpublish.yml to auto-deploy to PyPi on new release Ads API v7 (xdevplatform#251) * Removed scoped timeline endpoint * added granular tap placements * added advertiser business categories endpoint * updated serving_status to entity_status for media creatives * replaced reach estimate with audience summary * added audience summary and tests Add header for internal use (xdevplatform#252) * add internal header Bump version (xdevplatform#253) Merge across forks to get CI working (xdevplatform#265) (xdevplatform#266) * Add store identifiers to line item * bump version Create python-package.yml Update python-package.yml Update python-package.yml Update python-package.yml removed windows removed python 3.8 Update python-package.yml remove pypy Update python-package.yml
tushdante
added a commit
to tushdante/twitter-python-ads-sdk
that referenced
this pull request
Sep 8, 2021
# The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: Create pythonpublish.yml Testing CI/CD integration Update pythonpublish.yml Update __init__.py Update __init__.py Add github actions (xdevplatform#249) * Added pythonpublish.yml to auto-deploy to PyPi on new release Ads API v7 (xdevplatform#251) * Removed scoped timeline endpoint * added granular tap placements * added advertiser business categories endpoint * updated serving_status to entity_status for media creatives * replaced reach estimate with audience summary * added audience summary and tests Add header for internal use (xdevplatform#252) * add internal header Bump version (xdevplatform#253) Merge across forks to get CI working (xdevplatform#265) (xdevplatform#266) * Add store identifiers to line item * bump version Create python-package.yml Update python-package.yml Update python-package.yml Update python-package.yml removed windows removed python 3.8 Update python-package.yml remove pypy Update python-package.yml # The 2nd commit message will be skipped: # Update pythonpublish.yml # The 2nd commit message will be skipped: # Add github actions (xdevplatform#249) # # * Added pythonpublish.yml to auto-deploy to PyPi on new release # The 2nd commit message will be skipped: # Add header for internal use (xdevplatform#252) # # * add internal header # The 2nd commit message will be skipped: # Merge across forks to get CI working (xdevplatform#265) (xdevplatform#266) # # * Add store identifiers to line item # # * bump version
osowskit
pushed a commit
that referenced
this pull request
Nov 17, 2021
* Create pythonpublish.yml Testing CI/CD integration * Update pythonpublish.yml * Update __init__.py * Update __init__.py * Create python-package.yml * Update python-package.yml * Update python-package.yml * Update python-package.yml * removed windows * removed python 3.8 * Update python-package.yml * remove pypy * Update python-package.yml * Create pythonpublish.yml Testing CI/CD integration Update pythonpublish.yml Update __init__.py Update __init__.py Add github actions (#249) * Added pythonpublish.yml to auto-deploy to PyPi on new release Ads API v7 (#251) * Removed scoped timeline endpoint * added granular tap placements * added advertiser business categories endpoint * updated serving_status to entity_status for media creatives * replaced reach estimate with audience summary * added audience summary and tests Add header for internal use (#252) * add internal header Bump version (#253) Merge across forks to get CI working (#265) (#266) * Add store identifiers to line item * bump version Create python-package.yml Update python-package.yml Update python-package.yml Update python-package.yml removed windows removed python 3.8 Update python-package.yml remove pypy Update python-package.yml * # This is a combination of 2 commits. # The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: # This is a combination of 2 commits. # The first commit's message is: Create pythonpublish.yml Testing CI/CD integration Update pythonpublish.yml Update __init__.py Update __init__.py Add github actions (#249) * Added pythonpublish.yml to auto-deploy to PyPi on new release Ads API v7 (#251) * Removed scoped timeline endpoint * added granular tap placements * added advertiser business categories endpoint * updated serving_status to entity_status for media creatives * replaced reach estimate with audience summary * added audience summary and tests Add header for internal use (#252) * add internal header Bump version (#253) Merge across forks to get CI working (#265) (#266) * Add store identifiers to line item * bump version Create python-package.yml Update python-package.yml Update python-package.yml Update python-package.yml removed windows removed python 3.8 Update python-package.yml remove pypy Update python-package.yml # The 2nd commit message will be skipped: # Update pythonpublish.yml # The 2nd commit message will be skipped: # Add github actions (#249) # # * Added pythonpublish.yml to auto-deploy to PyPi on new release # The 2nd commit message will be skipped: # Add header for internal use (#252) # # * add internal header # The 2nd commit message will be skipped: # Merge across forks to get CI working (#265) (#266) # # * Add store identifiers to line item # # * bump version * updated audience_summary to audience_estimate * removed automatically_select_bid from line items * updated example * update to v10 Co-authored-by: Tom Osowski <tosowski@twitter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra header option for internal use