Add new Line Item fields for MAP objectives#264
Closed
osowskit wants to merge 4 commits intoxdevplatform:masterfrom
Closed
Add new Line Item fields for MAP objectives#264osowskit wants to merge 4 commits intoxdevplatform:masterfrom
osowskit wants to merge 4 commits intoxdevplatform:masterfrom
Conversation
Contributor
Author
|
I still need to bump the version |
Contributor
Author
|
@tushdante could you help get this merged and release a new SDK? |
tushdante
approved these changes
Sep 23, 2020
Contributor
tushdante
left a comment
tushdante
left a comment
There was a problem hiding this comment.
Might wanna check our tests to verify if things need to be updated there as well, but otherwise LGTM
Contributor
Author
|
Cross fork CI builds won't work. Closing this and following up in #266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new iOS and Android app store identifiers on the line items endpoint. Announcement. This is part of the
line_item_appsdeprecation and that endpoint will be removed mid-Sept.Note existing values set on the
line_item_appswill automatically be used by the line_items endpoint.closes #263