v9 update for TA->CA #278
Merged
v9 update for TA->CA #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udiences_permissions_all.json
|
|
tushdante
approved these changes
Apr 27, 2021
Contributor
tushdante
left a comment
tushdante
left a comment
There was a problem hiding this comment.
Minor change requested but otherwise LGTM!
| @@ -25,7 +25,7 @@ | |||
| "deleted": false | |||
| } | |||
| ], | |||
| "data_type": "tailored_audience_permission", | |||
Contributor
There was a problem hiding this comment.
@BJapac can you remove the data_type field from the golden data? Might make sense to regenerate these given that the API response has likely changed.
jbabichjapan
approved these changes
Apr 28, 2021
robi-ng
added a commit
to nugit/twitter-python-ads-sdk
that referenced
this pull request
May 19, 2021
This reverts commit 17ffd57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated files for TA->CA v9 changes, including class, tests, example files.