Skip to content

Update Cards to switch to ios_app_store_identifier and deprecate ipad params #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osowskit merged 2 commits into from
Nov 17, 2021
Merged

Update Cards to switch to ios_app_store_identifier and deprecate ipad params #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a49fa
Update Cards to switch to ios_app_store_identifier and deprecate ipad…
Sep 10, 2021
7dc302c
Remove deprecated salt field
Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/fixtures/accounts_all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"timezone_switch_at": "2014-11-17T08:00:00Z",
"id": "2iqph",
"created_at": "2015-03-04T10:50:42Z",
"salt": "5ab2pizq7qxjjqrx3z67f4wbko61o7xs",
"updated_at": "2015-04-11T05:20:08Z",
"approval_status": "ACCEPTED",
"deleted": false
Expand All @@ -20,7 +19,6 @@
"timezone_switch_at": "2014-11-17T08:00:00Z",
"id": "pz6ec",
"created_at": "2015-05-29T00:52:16Z",
"salt": "39ku32xvhdt0jax8thps2c70e2fv3yok",
"updated_at": "2015-05-29T00:52:16Z",
"approval_status": "ACCEPTED",
"deleted": false
Expand All @@ -31,7 +29,6 @@
"timezone_switch_at": "2014-11-17T08:00:00Z",
"id": "j9ozo",
"created_at": "2015-05-01T12:08:10Z",
"salt": "winwfne3y6oyikl4tm84bj9r50waxj37",
"updated_at": "2015-05-01T12:08:10Z",
"approval_status": "ACCEPTED",
"deleted": false
Expand All @@ -42,7 +39,6 @@
"timezone_switch_at": "2014-11-17T08:00:00Z",
"id": "9ttgd",
"created_at": "2015-06-24T18:51:20Z",
"salt": "tj9hmt5xylm5zztrq05w7hwh4mkpkg5r",
"updated_at": "2015-06-26T06:13:24Z",
"approval_status": "ACCEPTED",
"deleted": false
Expand All @@ -53,7 +49,6 @@
"timezone_switch_at": "2013-05-22T07:00:00Z",
"id": "47d0v",
"created_at": "2015-05-28T05:42:03Z",
"salt": "1ms1mq1nww7zl7169865gwqt89s9127m",
"updated_at": "2015-05-28T05:42:03Z",
"approval_status": "ACCEPTED",
"deleted": false
Expand Down
1 change: 0 additions & 1 deletion twitter_ads/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ def cards(self, id=None, **kwargs):
# account properties
resource_property(Account, 'id', readonly=True)
resource_property(Account, 'name', readonly=True)
resource_property(Account, 'salt', readonly=True)
resource_property(Account, 'timezone', readonly=True)
resource_property(Account, 'approval_status', readonly=True)
resource_property(Account, 'deleted', readonly=True, transform=TRANSFORM.BOOL)
Expand Down
18 changes: 6 additions & 12 deletions twitter_ads/creative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,8 @@ class ImageAppDownloadCard(Resource, Persistence):
# writable
resource_property(ImageAppDownloadCard, 'country_code')
resource_property(ImageAppDownloadCard, 'app_cta')
resource_property(ImageAppDownloadCard, 'iphone_app_id')
resource_property(ImageAppDownloadCard, 'iphone_deep_link')
resource_property(ImageAppDownloadCard, 'ipad_app_id')
resource_property(ImageAppDownloadCard, 'ipad_deep_link')
resource_property(ImageAppDownloadCard, 'ios_app_store_identifier')
resource_property(ImageAppDownloadCard, 'ios_deep_link')
resource_property(ImageAppDownloadCard, 'googleplay_app_id')
resource_property(ImageAppDownloadCard, 'googleplay_deep_link')
resource_property(ImageAppDownloadCard, 'name')
Expand Down Expand Up @@ -242,10 +240,8 @@ class VideoAppDownloadCard(Resource, Persistence):
resource_property(VideoAppDownloadCard, 'country_code')
resource_property(VideoAppDownloadCard, 'app_cta')
resource_property(VideoAppDownloadCard, 'poster_media_key')
resource_property(VideoAppDownloadCard, 'ipad_app_id')
resource_property(VideoAppDownloadCard, 'ipad_deep_link')
resource_property(VideoAppDownloadCard, 'iphone_app_id')
resource_property(VideoAppDownloadCard, 'iphone_deep_link')
resource_property(VideoAppDownloadCard, 'ios_app_store_identifier')
resource_property(VideoAppDownloadCard, 'ios_deep_link')
resource_property(VideoAppDownloadCard, 'googleplay_app_id')
resource_property(VideoAppDownloadCard, 'googleplay_deep_link')
resource_property(VideoAppDownloadCard, 'name')
Expand Down Expand Up @@ -530,10 +526,8 @@ def reload(self):
resource_property(CardsFetch, 'image', readonly=True)
resource_property(CardsFetch, 'image_display_height', readonly=True)
resource_property(CardsFetch, 'image_display_width', readonly=True)
resource_property(CardsFetch, 'ipad_app_id', readonly=True)
resource_property(CardsFetch, 'ipad_deep_link', readonly=True)
resource_property(CardsFetch, 'iphone_app_id', readonly=True)
resource_property(CardsFetch, 'iphone_deep_link', readonly=True)
resource_property(CardsFetch, 'ios_app_store_identifier', readonly=True)
resource_property(CardsFetch, 'ios_deep_link', readonly=True)
resource_property(CardsFetch, 'name', readonly=True)
resource_property(CardsFetch, 'recipient_user_id', readonly=True)
resource_property(CardsFetch, 'second_choice', readonly=True)
Expand Down