Rename user_ids to user_id in Account#timeline #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* added support for lookalike expansion * update references to country_code * removed videos endpoint * updated spec files * removed additional references to videos endpoint; updated the spec as well
* Tailored Audience for v4
* update twitter-ads version to 4.0.1 * update rubocop.yml and tailored_audience.rb
* Added support for MEDIA_CREATIVE stats * added support for card_uris * updated example for v5 * updated TC line_item_id to line_item_ids * added support for with_draft * remove preview_url from all cards endpoints
* Add a comment to TailoredAudience.users * Rename create_instance to create The current create method will no longer be supported as of v4. * Delele unused methods
* Remove CI guards * Start upgrade to min 2.3. Rubocop auto fixes * Disable and update a handful of Rubocop warnings Disabled Linting warnings on using Void and URI:Escape * Update copyright * Test ruby 2.3+ on Travis CI * Add Ruby 2.6 to build matrix and correct copyright lint * Minor fix to copyright * Add rubocop as separate step to display errors * Make rubocop verbose to help debugging * Remove erroneous newline * Fix merge conflicts * Revert "Remove CI guards" This reverts commit 85db938. * Update supported Ruby versions and bump license year * Update LICENSE * Fix merge conflicts
* Add ActiveEntities support * Update style
* Fix promoted_tweet example * Fix TypeError > no implicit conversion of nil into Hash (TypeError) when with_deleted is false
* Update .travis.yml * Update README We no longer test JRuby since xdevplatform#133 * Set min version to 2.4 * Allow bundler 2 * Update .rubocop.yml
smaeda-ks
force-pushed
the
rename-user_ids-to-user_id-in-account-timeline
branch
from
b46c150 to
96fa7b6
Compare
smaeda-ks
approved these changes
Jun 18, 2019
Contributor
|
Hmm, hound's status reporting seems stuck somehow. I'll try close -> re-open this PR to see if that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
According to the official document, it seems that the parameter name should be
user_idinstead ofuser_idsat the endpoint GET accounts/:account_id/scoped_timeline. I have attached the fix for this.https://developer.twitter.com/en/docs/ads/creatives/api-reference/tweets.html
I would be great if you could review and merge my commit.