Chore/docs #31
Merged
Chore/docs #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikicz
reviewed
Jul 26, 2023
| } else { | ||
| cells.push(Cell::new(current_selection.clone())); | ||
| current_selection = String::new(); | ||
| for char in row.chars() { |
Collaborator
There was a problem hiding this comment.
Is the old version not required anymore? Was there not a reason why you did it like that?
Collaborator
Author
There was a problem hiding this comment.
not that I can see, writing comments for it made me realise a lot of the conditions were unnecessary. This was actually just transliterated from your original code in python, I didn't really touch this bit of logic
Collaborator
Author
There was a problem hiding this comment.
can remove the changes if you prefer
Collaborator
There was a problem hiding this comment.
Can you check it works in onboarding portal as well, if yes, sure, it can stay
Collaborator
Author
There was a problem hiding this comment.
all onboarding tests pass
mikicz
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.