Skip to content

Conversation

@xerial
Copy link
Owner

@xerial xerial commented May 5, 2020

@xerial xerial marked this pull request as draft May 5, 2020 22:11
@xerial xerial marked this pull request as ready for review May 5, 2020 22:40
@xerial xerial requested a review from maropu May 5, 2020 22:41
@xerial xerial force-pushed the purejava-snappy branch from 9df8f99 to befa9a1 Compare May 6, 2020 18:04
@maropu
Copy link
Collaborator

maropu commented May 9, 2020

The SnappyApi abstraction looks fine, but do we need to copy the airlift implementation into our codebase? Any reason not to add the dependency then write delegation code for it in PureJavaSnappy?

@xerial
Copy link
Owner Author

xerial commented May 9, 2020

aircompressor adds extra dependencies to hadoop ecosystem, guava, etc. Most of them looks like just test/provided dependencies, but porting code would be easier to maintain for us as snappy algorithm will not be changed so much.

And also aircompressor has snappy-java dependency that creates circular dependency ...

@xerial
Copy link
Owner Author

xerial commented May 10, 2020

Rather, aircompressor will be in trouble if we reference their jar. It will put new and old class files of aircompressor in their classpath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants