chore: fix pre-existing repo hygiene issues#973
Merged
Conversation
The dep array already satisfies react-hooks/exhaustive-deps, so the eslint-disable directive was dead (flagged as an unused directive). Convert it to a plain comment that keeps the ref-exclusion rationale.
The 0.7.31 version bump updated the five tracked manifest files but not Cargo.lock, leaving the vmark package pinned at 0.7.30. Resync so the lockfile matches Cargo.toml (cargo regenerates it on every build otherwise).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, independent cleanups for two pre-existing defects on
main(unrelated to PR #972 or any feature work).Fixes
Cargo.lock— the 0.7.31 version bump updated the five tracked manifest files but notCargo.lock, leaving thevmarkpackage pinned at0.7.30. Anycargoinvocation silently regenerated it as dirty working state. Resynced to0.7.31(one-line change).SourcePane.tsx— the dep array already satisfiedreact-hooks/exhaustive-deps, so the directive was dead (eslint flagged it as an unused directive — the one warningpnpm lintemitted). Converted to a plain comment that preserves the ref-exclusion rationale.Not included (deliberately)
websocketqueue-full,parentProcesswin32) — also pre-existing, but fixed in fix: resolve 11 audit issues + repair audit-fix pipeline #972 (same file area as that PR's [audit] mcp-bridge: queueRequest timer rejects after flushRequestQueue drains, racing in-flight sendImmediate #959 work).cargo test, not clippy). Out of scope for a hygiene pass; touching unrelated code carries more risk than value here.Verification
pnpm lintclean (0 problems, was 1 warning);pnpm build, website build,cargo check, and the SplitPaneEditor test suite all pass.