Fix golangci-lint v2 config - disable default linters#366
Merged
Conversation
- Explicitly disable govet, staticcheck, unused (enabled by default in v2) - Add gosec.excludes to disable G104 (unhandled errors, similar to errcheck) - This matches the original v1 behavior more closely - Reduces linting errors from many to just 1 (G705 XSS warning)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 30 30
Lines 924 924
=======================================
Hits 922 922
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the golangci-lint v2 configuration to properly disable default linters and match the original v1 behavior.
Problem
In golangci-lint v2, several linters are enabled by default even if not explicitly listed in the
enablesection:govetstaticcheckunusedThis caused many new linting errors that didn't exist with the v1 config.
Solution
Explicitly Disable Default Linters
Added to the
disablelist:govetstaticcheckunusedConfigure gosec to Exclude G104
Added gosec settings to exclude G104 (unhandled errors), which is similar to the disabled
errchecklinter:Results
Before this fix:
After this fix:
Verification
✅
golangci-lint config verifypasses✅
golangci-lint runnow produces minimal output matching v1 behavior