-
Notifications
You must be signed in to change notification settings - Fork 74
Refactor to separate wasm bindings from rust crate #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelx11
merged 5 commits into
main
from
refactor-to-separate-wasm-bindings-from-rust-crate
Feb 3, 2023
Merged
Refactor to separate wasm bindings from rust crate #1
michaelx11
merged 5 commits into
main
from
refactor-to-separate-wasm-bindings-from-rust-crate
Feb 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzz
approved these changes
Feb 3, 2023
This was referenced Sep 26, 2025
Closed
This was referenced Oct 3, 2025
Closed
Closed
This was referenced Oct 10, 2025
Closed
This was referenced Nov 21, 2025
Open
Merged
This was referenced Dec 2, 2025
Merged
Merged
This was referenced Dec 9, 2025
Merged
Merged
This was referenced Dec 17, 2025
This was referenced Jan 8, 2026
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR follows the structure of other example Rust crossplatform libraries I've seen (link)
The structure is:
In this case it manifests as:
bindings/wasmsubdirectoryChanges
ethers-rsjust to show we can, and generate a mnemonic to show we can exercise codebindings/wasmwe add a dependency onxmtp-keystore, modify the API, and add tests to exercisegenerateMnemonicTesting
npm run prepublishOnlynow shows two tests running successfully.