switch hkdf to use RustCrypto hdkf and sha2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzz
approved these changes
Feb 7, 2023
crates/xmtp-keystore/src/lib.rs
Outdated
| } else { | ||
| Err(ring::error::Unspecified) | ||
| fn hkdf(secret: &[u8], salt: &[u8]) -> Result<[u8; 32], String> { | ||
| let hk = Hkdf::<Sha256>::new(Some(&salt[..]), &secret); |
Contributor
There was a problem hiding this comment.
Is the range operator needed here on salt?
jazzz
reviewed
Feb 7, 2023
Co-authored-by: Jazz Turner-Baggs <473256+jazzz@users.noreply.github.com>
This was referenced Oct 2, 2025
Closed
This was referenced Oct 10, 2025
Closed
Closed
This was referenced Oct 20, 2025
Merged
Closed
This was referenced Nov 12, 2025
Merged
Merged
Merged
This was referenced Nov 21, 2025
Open
Merged
This was referenced Dec 2, 2025
Merged
Open
This was referenced Dec 9, 2025
Merged
This was referenced Dec 17, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
@jazzz made the excellent suggestion to use RustCrypto libraries. NCC has audited most of their repos and:
I also think the APIs are simpler than
ringChanges
Swap out the
Keystore::hkdfimplementation to use RustCrypto'shkdfandsha2crates. Confirm tests still pass.Tests
Unit test vectors for
hkdfstill pass