Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jul 30, 2025

Fix gateway configuration and initialization by renaming binary to xmtpd-gateway, adding development script, and updating component startup

  • Renames the gateway binary from xmtpd to xmtpd-gateway in dev/docker/gateway.Dockerfile and updates the Docker entrypoint accordingly
  • Adds a new development script dev/gateway that configures environment variables and runs the gateway on ports 5052 and 5057
  • Reorganizes gateway-related environment variables under a dedicated section in dev/local.env
  • Removes the required Prometheus registry check in pkg/api/server.go initialization
  • Adds explicit chainRegistry.Start() call in pkg/gateway/builder.go
  • Adds JSON contract configuration parsing to LoadConfigFromEnv function in pkg/gateway/helpers.go

📍Where to Start

Start with the LoadConfigFromEnv function in pkg/gateway/helpers.go to understand the configuration loading changes, then review the gateway builder initialization in pkg/gateway/builder.go.

Changes since #1003 opened

  • Consolidated gateway script functionality by removing separate gateway script and incorporating its configuration into the run-gateway script [6a0daab]
  • Updated environment variable configuration in the gateway script [6a0daab]

Macroscope summarized 6a0daab.

@mkysel mkysel requested a review from a team as a code owner July 30, 2025 18:36
@graphite-app
Copy link

graphite-app bot commented Jul 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

dev/gateway Outdated
@@ -0,0 +1,10 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a dev/run-gateway that looks nearly identical to this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. I will merge them

@mkysel mkysel merged commit 7538ae5 into main Jul 30, 2025
9 of 10 checks passed
@mkysel mkysel deleted the mkysel/fix-gateway branch July 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants