Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jul 31, 2025

This fixes upgrade tests and all the plumbing for XDBG.

There are a lot of issues with XDBG that prevent this from being fully operational.

@mkysel mkysel requested a review from a team as a code owner July 31, 2025 02:53
@graphite-app
Copy link

graphite-app bot commented Jul 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Jul 31, 2025

Fix XDBG tests by adding gateway container support and Docker build script

  • Adds new Docker build script dev/docker/build-gateway for creating XMTP gateway service images with git-based versioning
  • Introduces XmtpdGatewayContainerBuilder struct in pkg/integration/docker_utils_test.go for configuring gateway containers in integration tests
  • Updates XdbgContainerBuilder to support separate gateway and target addresses through new WithGatewayTarget method
  • Modifies test setup in pkg/integration/main_test.go to build gateway development images
  • Updates XDBG image version from sha-78a5ac2 to sha-26bb960 and removes XMTPD_PAYER_ENABLE environment variable
  • Adds gateway container testing to TestLatestVersion in pkg/integration/upgrade_test.go
  • Temporarily disables TestXDBGRealMLSPayloads in pkg/integration/xdbg_test.go while adding gateway configuration

📍Where to Start

Start with the new buildGatewayDevImage function in pkg/integration/docker_utils_test.go to understand how the gateway Docker image is built, then examine the XmtpdGatewayContainerBuilder struct in the same file to see how gateway containers are configured for testing.


Macroscope summarized 161e06c.

@mkysel mkysel merged commit ab7bf21 into main Jul 31, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/fix-xdbfg branch July 31, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants