Prevent dependsOn for non-commits: #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
neekolas
approved these changes
Aug 4, 2025
Contributor
neekolas
left a comment
neekolas
left a comment
There was a problem hiding this comment.
Straightforward way to prevent trouble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent messages from depending on non-commit nodes by adding validation in Service.validateClientInfo method to reject node IDs ≥ 100
The
Service.validateClientInfomethod in service.go now validates that messages cannot depend on node IDs ≥ 100, which represent non-commits, returning an error message "A message can not depend on a non-commit" when such dependencies are detected. A new testTestPublishEnvelolopeDependsOnOriginatorhas been added to publish_test.go to verify this validation behavior, and an existing test has been updated to use node ID 97 instead of 1600.📍Where to Start
Start with the
validateClientInfomethod in theServicestruct in service.go to understand the new validation logic for non-commit dependencies.Macroscope summarized 851c9f3.