Idempotent migration: do not migrate nodes with pubkey already registered #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fbac
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make node migration idempotent by preventing re-registration of nodes with existing public keys in the blockchain registry
The
migrateNodesCLI command now connects to the blockchain RPC to fetch existing registry nodes and passes both desired and existing nodes to the migrator. Themigrator.WriteToRegistryfunction checks for existing nodes by matchingSigningKeyPuband only adds them to the network instead of re-registering them, while new nodes are still added to the registry and optionally added to the network based onInCanonicalNetworkstatus.📍Where to Start
Start with the
migrateNodesCLI command changes in cmd/cli/main.go to understand how the migration process now fetches existing nodes from the blockchain registry.Macroscope summarized 303319f.