Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Aug 25, 2025

More to come. This just does the IU as a POC. The same command will do GM as well. We also need pause and unpause.

@mkysel mkysel requested a review from a team as a code owner August 25, 2025 17:58
@graphite-app
Copy link

graphite-app bot commented Aug 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Aug 25, 2025

Add get/set identity update bootstrapper address commands to the cmd/cli tool as the first stage of parameter CLI admin

This change adds subcommands to manage the identity update bootstrapper address via a new parameter administration layer and updates blockchain admins to use it.

  • Add get-bootstrapper-address and set-bootstrapper-address subcommands, options, and handlers in main.go, wiring through setupParameterAdmin and setupAppChainAdmin.
  • Introduce ParameterAdmin with address/uint8 get/set methods and constants in parameterAdmin.go.
  • Add IAppChainAdmin and NewAppChainAdmin with GetIdentityUpdateBootstrapper and SetIdentityUpdateBootstrapper in appchainAdmin.go.
  • Refactor NodeRegistryAdmin to consume ParameterAdmin in registryAdmin.go and update construction in node_registry.go.
  • Extend CLI option structs for these commands in cliOptions.go.

📍Where to Start

Start with parseOptions and the new command handlers in main.go, then follow into blockchain.NewAppChainAdmin and parameter operations in appchainAdmin.go and parameterAdmin.go.

Changes since #1070 opened

  • Reformatted method calls in blockchain package tests [8ea2e42]

Macroscope summarized 8ea2e42.

Copy link
Collaborator

@fbac fbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI needs some polishing tho :)

Give the PoC CLI a try, so we can discuss which one is more flexible and has the best devex.

@mkysel mkysel enabled auto-merge (squash) August 26, 2025 13:41
@mkysel mkysel merged commit acef67f into main Aug 26, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/parameter-cli branch August 26, 2025 13:42
@mkysel
Copy link
Collaborator Author

mkysel commented Aug 26, 2025

Partially implements #818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants