Pass contract options correctly #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require explicit
config.ContractsOptionsand payer private key inmigrator.NewMigrationServiceandmigrator.setupBlockchainPublisherto pass contract options correctly during migration setupThis refactor removes contracts from migration server config and makes the migrator require contract options and the payer private key explicitly.
contractstoDBMigratorConfig, introducemigrator.WithContractsOptions, and makemigrator.NewMigrationServicereturn error "contracts are required" when missing in migrator.gomigrator.setupBlockchainPublisherto acceptpayerPrivateKey stringand*config.ContractsOptions; update internal references and pass*cfgtoNewBlockchainPublisherin builder.goContractsfromconfig.MigrationServerOptionsin migration.gomigrator.WithContractsOptions(&cfg.Options.Contracts)from the server when migration is enabled in server.gomigrator.WithContractsOptionsin migrator_test.go📍Where to Start
Start with
migrator.NewMigrationServiceand the newWithContractsOptionspath in migrator.go, then follow the call intomigrator.setupBlockchainPublisherin builder.go.Macroscope summarized c65bb3e.