Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Sep 3, 2025

Add more pause CLI commands by extending cmd/cli/main.go setPause and getPause to control app-chain gateway, settlement-chain gateway, payer registry, and distribution manager via new blockchain.SettlementChainAdmin and updated blockchain.AppChainAdmin.

  • Expand CLI pause targets in main.go by wiring setPause/getPause to blockchain.AppChainAdmin and a new blockchain.SettlementChainAdmin, with setupSettlementChainAdmin handling settlement-chain admin construction.
  • Add settlementChainAdmin in settlementChainAdmin.go to bind to SettlementChainGateway, PayerRegistry, and DistributionManager and implement get/set pause with on-chain UpdatePauseStatus transactions and event parsing.
  • Extend appChainAdmin in appchainAdmin.go to bind AppChainGateway and add GetAppChainGatewayPauseStatus/SetAppChainGatewayPauseStatus.
  • Add pause parameter keys in parameterAdmin.go.
  • Update configuration for gateway and distribution manager addresses in chainConfig.go, options.go, validation.go, and extend target parsing in cliOptions.go; update test config in config.go.
  • Add and adjust tests in settlementchainAdmin_test.go and appchainAdmin_test.go.

📍Where to Start

Start with setPause, getPause, and setupSettlementChainAdmin in main.go, then review NewSettlementChainAdmin and pause setters/getters in settlementChainAdmin.go.

Changes since #1090 opened

  • Added contract address validations to CLI setup functions [78fb926]
  • Added TODO blocks for future gateway address validations [78fb926]
  • Updated error message in config.Target.UnmarshalFlag method to include all valid target values [1644423]
  • Added fallback configuration logic in config.fillConfigFromJson function [174dee8]

Macroscope summarized 174dee8.

@mkysel mkysel requested a review from a team as a code owner September 3, 2025 15:32
@graphite-app
Copy link

graphite-app bot commented Sep 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit 9da18ea into main Sep 3, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/more-pause branch September 3, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants