Rework rate manager to use param manager and add tests #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework rate management by modifying
blockchain.RatesAdminto useblockchain.ParameterAdminfor writing rate parameters and add tests acrosspkg/blockchain.RatesAdminto depend on a pre-builtParameterAdmin, changeblockchain.NewRatesAdminsignature, and refactorRatesAdmin.AddRatesto batch-set parameters viaParameterAdminbefore invoking the on-chain rates update in rates_admin.go.uint64get/set and batch parameter APIs, introduce broadcaster-specific keys, and reorganize parameter constants in parameterAdmin.go.ParameterAdminand pass it toNewRatesAdminin main.go and rate_registry.go.📍Where to Start
Start with the constructor
blockchain.NewRatesAdminand the methodblockchain.RatesAdmin.AddRatesin rates_admin.go.Macroscope summarized 2131512.