Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Sep 3, 2025

Rework rate management by modifying blockchain.RatesAdmin to use blockchain.ParameterAdmin for writing rate parameters and add tests across pkg/blockchain.

  • Update RatesAdmin to depend on a pre-built ParameterAdmin, change blockchain.NewRatesAdmin signature, and refactor RatesAdmin.AddRates to batch-set parameters via ParameterAdmin before invoking the on-chain rates update in rates_admin.go.
  • Add uint64 get/set and batch parameter APIs, introduce broadcaster-specific keys, and reorganize parameter constants in parameterAdmin.go.
  • Adjust CLI setup to construct ParameterAdmin and pass it to NewRatesAdmin in main.go and rate_registry.go.
  • Switch pause status keys to broadcaster-specific variants in appchainAdmin.go.
  • Add and update tests for rates admin, parameter admin (including batch flows), and pause keys in rates_admin_test.go, parameterAdmin_test.go, and appchainAdmin_test.go.

📍Where to Start

Start with the constructor blockchain.NewRatesAdmin and the method blockchain.RatesAdmin.AddRates in rates_admin.go.


Macroscope summarized 2131512.

@mkysel mkysel requested a review from a team as a code owner September 3, 2025 18:37
@graphite-app
Copy link

graphite-app bot commented Sep 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit e692c9e into main Sep 4, 2025
10 of 12 checks passed
@mkysel mkysel deleted the mkysel/rate-rework branch September 4, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants