Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Sep 4, 2025

Add parameter management for all missing app-chain and settlement-chain elements by introducing admin getters/setters for group and identity payload sizes and settlement parameters with uint16, uint32, uint64, and uint96 support in ParameterAdmin, with no CLI commands

This change adds missing parameter-management surfaces across the app-chain and settlement-chain admins and implements canonical encoding/decoding for multiple integer widths in the parameter admin.

  • Update appchainAdmin.go to add IAppChainAdmin methods for Get/SetGroupMessageMaxPayloadSize, Get/SetGroupMessageMinPayloadSize, Get/SetIdentityUpdateMaxPayloadSize, and Get/SetIdentityUpdateMinPayloadSize, persisting parameters and executing on-chain broadcaster updates with event parsing.
  • Update parameterAdmin.go to implement canonical pack/decode for uint8/uint16/uint32/uint64/uint96, add GetParameterUint16, GetParameterUint32, GetParameterUint96, and SetUint16Parameter, SetUint32Parameter, SetUint96Parameter, and refactor logging and batch packing to use the new helpers.
  • Update settlementChainAdmin.go to expand ISettlementChainAdmin with getters/setters for distribution manager protocol fees recipient, node registry admin, payer registry minimum deposit (uint96), withdraw lock period (uint32), payer report manager protocol fee rate (uint16), and rate registry migrator, executing relevant on-chain updates with event parsing where applicable.
  • Add tests in appchainAdmin_test.go, parameterAdmin_test.go, and settlementchainAdmin_test.go covering read/write flows, idempotency, and encoding boundaries.

📍Where to Start

Start with the packing/decoding helpers and new getters/setters in parameterAdmin.go, then review how they are used in settlementChainAdmin.go and appchainAdmin.go.

Changes since #1092 opened

  • Modified logging format for minimumDeposit field in blockchain.settlementChainAdmin.SetPayerRegistryMinimumDeposit method [8c1f294]

Macroscope summarized 8c1f294.

@mkysel mkysel requested a review from a team as a code owner September 4, 2025 15:00
@graphite-app
Copy link

graphite-app bot commented Sep 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit 5ae0b07 into main Sep 4, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/all-others branch September 4, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants