Param management for all missing elements. No CLI commands yet #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter management for all missing app-chain and settlement-chain elements by introducing admin getters/setters for group and identity payload sizes and settlement parameters with uint16, uint32, uint64, and uint96 support in
ParameterAdmin, with no CLI commandsThis change adds missing parameter-management surfaces across the app-chain and settlement-chain admins and implements canonical encoding/decoding for multiple integer widths in the parameter admin.
IAppChainAdminmethods forGet/SetGroupMessageMaxPayloadSize,Get/SetGroupMessageMinPayloadSize,Get/SetIdentityUpdateMaxPayloadSize, andGet/SetIdentityUpdateMinPayloadSize, persisting parameters and executing on-chain broadcaster updates with event parsing.GetParameterUint16,GetParameterUint32,GetParameterUint96, andSetUint16Parameter,SetUint32Parameter,SetUint96Parameter, and refactor logging and batch packing to use the new helpers.ISettlementChainAdminwith getters/setters for distribution manager protocol fees recipient, node registry admin, payer registry minimum deposit (uint96), withdraw lock period (uint32), payer report manager protocol fee rate (uint16), and rate registry migrator, executing relevant on-chain updates with event parsing where applicable.📍Where to Start
Start with the packing/decoding helpers and new getters/setters in parameterAdmin.go, then review how they are used in settlementChainAdmin.go and appchainAdmin.go.
Changes since #1092 opened
Macroscope summarized 8c1f294.