Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Sep 4, 2025

No description provided.

@mkysel mkysel requested a review from a team as a code owner September 4, 2025 17:12
@graphite-app
Copy link

graphite-app bot commented Sep 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel
Copy link
Collaborator Author

mkysel commented Sep 4, 2025

@macroscopeapp summarize

@macroscopeapp
Copy link

macroscopeapp bot commented Sep 4, 2025

Add all missing settlement‑chain administrative CLI subcommands in cmd/cli/main.go and enforce typed address parsing across node registration and admin operations

  • Add CLI subcommands in main.go for getting/setting node registry admin, payload size bounds (min|max) for identity/group, DistributionManager protocol fees recipient, payer minimum deposit (microdollars), payer withdraw lock (seconds), PayerReportManager fee rate (uint16 bps), and RateRegistry migrator, and route them in main.
  • Introduce AddressFlag and migrate CLI option structs to typed common.Address in cliOptions.go; update register‑node, bootstrapper setters, stress, and watcher to use typed addresses.
  • Change INodeRegistryAdmin.AddNode to accept common.Address and update implementation and callers in registry_admin.go, migrator.go, and node_registry.go; adjust tests accordingly.
  • Add MicroDollar and update currency conversions in currency.go; adapt PayerRegistry event handlers in payer_registry_storer.go.
  • Fix group message bootstrapper getter and standardize typed address usage across handlers, stress, and watcher paths.

📍Where to Start

Start with parseOptions and the new command handlers in main.go, then review the option definitions and AddressFlag in cliOptions.go, followed by the INodeRegistryAdmin.AddNode signature change in registry_admin.go.


Macroscope summarized baf4be2.

@mkysel mkysel merged commit 1299d55 into main Sep 5, 2025
10 of 11 checks passed
@mkysel mkysel deleted the mkysel/missing-CLI branch September 5, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants